-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: drop 3.8 support #1983
Conversation
b7d603e
to
9ab61f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay with dropping 3.8 for Ape v0.8
For now, if the move to add official 3.12 support can be added to downstream ApeWorX packages firs, and then to Ape within 0.7.x series, they can be accomplished non-breaking
9ab61f7
to
29ae93d
Compare
I also think some of our processes were using 3.8 since as type checking, linting, and docs They can maybe upgrade to 3.9 or 3.11 (not sure which is better) |
f2a565c
to
56a0013
Compare
Co-authored-by: NotPeopling2day <[email protected]>
29ae93d
to
c6b0877
Compare
Processes are all using 3.10 as far as I can tell, I don't know what is best either. |
72ba791
to
eb41c60
Compare
eb41c60
to
175b031
Compare
i've been devving on 3.12 and haven't seen any issues. i'm pro dropping 3.9 too, dropping just 3.8 doesn't offer much interesting features. installing any python version is trivial nowadays with |
the main issue on 3.12 right now (which is soon to be fixed) is that there are some Ethereum packages importing from pkg_resources which may not be installed. We are soon to having this fully fixed, there is a separate PR for it.
We are trying to wait closer to EOL for 3.9. There is actually a nice 3.8drop affordance we gained - typing improvements. No longer are we cursed to importing |
@antazoey I tried to resolve the merge conflicts but please double check! |
83f190b
to
8c8881f
Compare
8c8881f
to
48a959c
Compare
What I did
requires:
ApeWorX/eip712#44
ApeWorX/evm-trace#59
ApeWorX/ethpm-types#118
ApeWorX/eth-pydantic-types#7
ApeWorX/evmchains#7
fixes: #
note: changes from running
pyupgrade --py39-plus
How I did it
How to verify it
Checklist